Skip to content

Conversation

oguzhankoral
Copy link
Member

@oguzhankoral oguzhankoral commented Sep 6, 2024

Reverting the mistake that caused important regression on autocad. TESTED, see gif

acad_2PMJkxaSBS

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 7.46%. Comparing base (ddccb44) to head (1edcb07).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #223   +/-   ##
=====================================
  Coverage   7.46%   7.46%           
=====================================
  Files        239     239           
  Lines       4624    4624           
  Branches     544     544           
=====================================
  Hits         345     345           
  Misses      4264    4264           
  Partials      15      15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JR-Morgan JR-Morgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change wasn't an intentional inclusion in #159

Feel free to merge, but I am suspicious that this part of the code has potential for deadlocks and race conditions.
Perhaps we can take a look after the next beta

@oguzhankoral oguzhankoral merged commit f1a5a4c into dev Sep 6, 2024
5 checks passed
@oguzhankoral oguzhankoral deleted the oguzhan/fix-browser-dispatcher-invoke branch September 6, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants