Skip to content

Conversation

adamhathcock
Copy link
Member

No description provided.

Copy link

linear bot commented Sep 9, 2024

Copy link

gitguardian bot commented Sep 9, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 7.46%. Comparing base (0a568ac) to head (02d4422).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
Sdk/Speckle.Connectors.Utils/Connector.cs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #228   +/-   ##
=====================================
  Coverage   7.46%   7.46%           
=====================================
  Files        239     239           
  Lines       4624    4624           
  Branches     544     544           
=====================================
  Hits         345     345           
  Misses      4264    4264           
  Partials      15      15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AlanRynne AlanRynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should go into main right? Otherwise everything is good

@adamhathcock
Copy link
Member Author

I guess it should go to both. I'll put it on main so we can put it in dev

@adamhathcock
Copy link
Member Author

Actually, this class is newer than the current main :)

Main is like 2 months old, that doesn't seem right 🤔

@AlanRynne AlanRynne self-requested a review September 10, 2024 12:37
Copy link
Contributor

@AlanRynne AlanRynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, we still need to do the merge to main. Approving into dev for now, it'll make it's way there

@adamhathcock adamhathcock enabled auto-merge (squash) September 10, 2024 13:58
@adamhathcock adamhathcock merged commit 7e4125c into dev Sep 10, 2024
4 checks passed
@adamhathcock adamhathcock deleted the adam/cxpla-47-update-v3-connectors-to-use-new-seq-endpoint-auth branch September 10, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants