Skip to content

Conversation

JR-Morgan
Copy link
Member

@JR-Morgan JR-Morgan commented Nov 29, 2024

When Top level exception toasts fail to display, the exception message is lost

Here, I've adjusted the top level exception handler behaviour to handle toast faliures with an aggregate exception, and provide a better exception message when this occurs.

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 9.36%. Comparing base (d0e77d2) to head (e1e45ac).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
....Connectors.DUI/Bridge/TopLevelExceptionHandler.cs 73.33% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             dev    #423      +/-   ##
========================================
+ Coverage   9.30%   9.36%   +0.05%     
========================================
  Files        224     224              
  Lines       4234    4241       +7     
  Branches     471     471              
========================================
+ Hits         394     397       +3     
- Misses      3824    3828       +4     
  Partials      16      16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JR-Morgan JR-Morgan enabled auto-merge (squash) November 29, 2024 13:33
@JR-Morgan JR-Morgan merged commit 2e41d15 into dev Nov 29, 2024
5 checks passed
@JR-Morgan JR-Morgan deleted the jrm/failed-toast-message branch November 29, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants