Skip to content

fix: forces detail level to fine for specific elements #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 3, 2024
Merged

fix: forces detail level to fine for specific elements #425

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0a0a135
fix: forces detail level to fine for specific elements
didimitrie Nov 29, 2024
0100c67
Merge branch 'dev' into dimitrie/cnx-850-pipe-fittings-not-exported
didimitrie Nov 29, 2024
437e948
Merge branch 'dev' into dimitrie/cnx-850-pipe-fittings-not-exported
didimitrie Dec 2, 2024
c3f2115
Merge branch 'dev' into dimitrie/cnx-850-pipe-fittings-not-exported
oguzhankoral Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions Converters/Revit/Speckle.Converters.RevitShared/Helpers/DisplayValueExtractor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
using Microsoft.Extensions.Logging;
using Speckle.Converters.Common;
using Speckle.Converters.Common.Objects;
using Speckle.Converters.RevitShared.Extensions;
using Speckle.Converters.RevitShared.Settings;
using Speckle.Sdk.Common;

Expand Down Expand Up @@ -98,6 +99,23 @@ IConverterSettingsStore<RevitConversionSettings> converterSettings
//options = ViewSpecificOptions ?? options ?? new Options() { DetailLevel = DetailLevelSetting };
options ??= new DB.Options { DetailLevel = _detailLevelMap[_converterSettings.Current.DetailLevel] };

// Note: some elements do not get display values (you get invalid solids) unless we force the view detail level to be fine. This is annoying, but it's bad ux: people think the
// elements are not there (they are, just invisible).
if (
element.Category is not null
&& (
element.Category.GetBuiltInCategory() == DB.BuiltInCategory.OST_PipeFitting
|| element.Category.GetBuiltInCategory() == DB.BuiltInCategory.OST_PipeAccessory
|| element.Category.GetBuiltInCategory() == DB.BuiltInCategory.OST_PlumbingFixtures
#if REVIT2024_OR_GREATER
|| element is DB.Toposolid // note, brought back from 2.x.x.
#endif
)
)
{
options.DetailLevel = DB.ViewDetailLevel.Fine;
}

DB.GeometryElement geom;
try
{
Expand Down
Loading