Skip to content

Conversation

clairekuang
Copy link
Member

  • adds support for sending surfaces and regions as meshes
  • adds brep to mesh raw converter
  • refactors existing solid and body converters to use new brep converter to avoid duplicate logic

before:
https://latest.speckle.systems/projects/25d1713b7f/models/87d7a331a8@031076f7e9#threadId=0912fbdc42

after:
https://latest.speckle.systems/projects/2295cb26a0/models/7c9dc1dcd8@12c41008e6

also adds brep raw converter and refactors existing converters to avoid duplicate logic
Copy link

linear bot commented Dec 1, 2024

Copy link

codecov bot commented Dec 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.31%. Comparing base (332ab25) to head (aab44d0).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #428   +/-   ##
=====================================
  Coverage   9.31%   9.31%           
=====================================
  Files        225     225           
  Lines       4263    4263           
  Branches     484     484           
=====================================
  Hits         397     397           
  Misses      3850    3850           
  Partials      16      16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@didimitrie
Copy link
Member

I've tested this with the existing sample file; unsure what other things to look at. Had some initial comments, but nothing really worth dropping in here.

@clairekuang clairekuang enabled auto-merge (squash) December 3, 2024 13:35
@clairekuang clairekuang merged commit f53e52b into dev Dec 3, 2024
5 checks passed
@clairekuang clairekuang deleted the claire/cnx-765-surfaces-and-regions-are-not-published branch December 3, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants