Skip to content

Fix transform temp #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 3, 2024
Merged

Fix transform temp #434

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4deacd6
Update SDK to 205
adamhathcock Dec 3, 2024
aa13606
Use NotNull
adamhathcock Dec 3, 2024
646c701
fmt
adamhathcock Dec 3, 2024
ed1ef62
Merge remote-tracking branch 'origin/dev' into update-sdks
adamhathcock Dec 3, 2024
e485f30
Temporary ITransformable fix for Revit
adamhathcock Dec 3, 2024
1726581
Merge remote-tracking branch 'origin/dev' into fix-transform-temp
adamhathcock Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Connectors/Revit/Speckle.Connectors.RevitShared/Operations/Receive/RevitHostObjectBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,13 +192,16 @@ localToGlobalMap.AtomicObject is ITransformable transformable // and ICurve
&& localToGlobalMap.AtomicObject["units"] is string units
)
{
var id = localToGlobalMap.AtomicObject.id;
ITransformable? newTransformable = null;
foreach (var mat in localToGlobalMap.Matrix)
{
transformable.TransformTo(new Transform() { matrix = mat, units = units }, out newTransformable);
transformable = newTransformable; // we need to keep the reference to the new object, as we're going to use it in the cache'
}

localToGlobalMap.AtomicObject = (newTransformable as Base)!;
localToGlobalMap.AtomicObject.id = id; // restore the id, as it's used in the cache'
localToGlobalMap.Matrix = new HashSet<Matrix4x4>(); // flush out the list, as we've applied the transforms already
}

Expand Down
Loading