Add Net8 targets for common and fix revit 2025 #444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #444 +/- ##
=====================================
Coverage 9.43% 9.43%
=====================================
Files 223 223
Lines 4209 4207 -2
Branches 487 487
=====================================
Hits 397 397
+ Misses 3796 3794 -2
Partials 16 16 ☔ View full report in Codecov by Sentry. |
JR-Morgan
approved these changes
Dec 11, 2024
| @@ -1,7 +1,7 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
|
|
|||
| <PropertyGroup> | |||
| <TargetFramework>netstandard2.0</TargetFramework> | |||
There was a problem hiding this comment.
why we need multi targeting for common project?
There was a problem hiding this comment.
all users of that project that are net8.0 will use the net8.0 version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was still having Revit 2025 build issues.
Since 25 doesn't depend on webview anymore (just Cef) then remove the dependency and blocker for me
Replaces #432