Dimitrie/cnx 917 steel proxy elements do not get converted out #445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i will remove them
…s reliable?) and removes local dependency refs
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #445 +/- ##
========================================
- Coverage 9.43% 9.43% -0.01%
========================================
Files 223 223
Lines 4207 4208 +1
Branches 487 487
========================================
Hits 397 397
- Misses 3794 3795 +1
Partials 16 16 ☔ View full report in Codecov by Sentry. |
oguzhankoral
approved these changes
Dec 11, 2024
oguzhankoral
deleted the
dimitrie/cnx-917-steel-proxy-elements-do-not-get-converted-out
branch
|
@didimitrie tested and issue seems to persist. |
didimitrie
restored the
dimitrie/cnx-917-steel-proxy-elements-do-not-get-converted-out
branch
|
Yep, i forgot to remove preprocessor directives and i assume you've tested with revit 23 or lower? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See linear ticket for details.
NOTE: @bimgeek I'd love to test against a more extensive file with more structural connectors/plates/welds/bolts. I have only tested vs. steel plates for now before we merge.
Alternatively, we can cut a release and ask the issue reporter on the forum (Andre) to give it a go.