Do some stack work to speed up Rhino hotspots #590
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://linear.app/speckle/issue/CNX-1324/improving-send-and-receive-perf
Tasked to do some profiling.
First change is to a converter hotspot that seems to speed up by doing some work on the stack then allocating for arrays instead of doing it upfront:
before:

after:

I didn't see a real difference in allocates but probably saves some capacity setting. It wouldn't expect a big difference because it is ultimately allocating for these values.
BrepEncoding is a big allocator:
before:

after:

It can probably be reduced by only doing the byte array then the serializer knows what to do with it (base64 later) to reduce memory usage
More to come...