fix(IFC): Fixed duplicate elements

[JR-Morgan]

Previously, we were selecting all spatial children to as RootIds to become immediate children of the root Collection speckle object. Additionally they were also included during traversal as spatial children to be nested under the "elements" property during recursive traversal.

Obviously these two strategies cannot both be employed without leading to the problem in question where many copies of each element was included in the tree.

(i.e. all spatial relationships were being sent flat AND included as nested children via the traversal)

See Linear ticket for an example Speckle model

Pre PR (slightly simplified)

  graph TD;
      Root_Collection--> IFC_Project;
      IFC_Project-->IFC_Site;
      IFC_Site-->IFC_Building;
      IFC_Building-->IFC_Storey;
      IFC_Storey-->IFC_Roof;
      Root_Collection-->IFC_Building;
      Root_Collection-->IFC_Site;
      Root_Collection-->IFC_Roof;

Loading

Post PR

  graph TD;
      Root_Collection-->IFC_Project;
      IFC_Project-->IFC_Site;
      IFC_Site-->IFC_Building;
      IFC_Building-->IFC_Storey;
      IFC_Storey-->IFC_Roof;

Loading

[linear]

CNX-1082 Duplicate IFC SPACES

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 8.71%. Comparing base (3ff4075) to head (afb1053).
Report is 1 commits behind head on dev.

Additional details and impacted files

@@          Coverage Diff          @@
##             dev    #604   +/-   ##
=====================================
  Coverage   8.71%   8.71%           
=====================================
  Files        227     227           
  Lines       4370    4370           
  Branches     545     545           
=====================================
  Hits         381     381           
  Misses      3974    3974           
  Partials      15      15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.