Skip to content

Conversation

adamhathcock
Copy link
Member

@adamhathcock adamhathcock commented Feb 19, 2025

Part of https://linear.app/speckle/issue/CNX-1324/improving-send-and-receive-perf

Since Autocad calls object changed on each receive, this shaves off 7 seconds off my test. Also fixes a namespace

Should talk about Transactions vs StartStop ones

before:
Screenshot 2025-02-19 161647

after:
Screenshot 2025-02-19 173121

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 8.66%. Comparing base (9d5faa9) to head (5858fd8).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...3/Speckle.Connectors.DUI/Bridge/IdleCallManager.cs 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             dev    #609      +/-   ##
========================================
- Coverage   8.71%   8.66%   -0.05%     
========================================
  Files        227     227              
  Lines       4374    4374              
  Branches     546     547       +1     
========================================
- Hits         381     379       -2     
- Misses      3978    3979       +1     
- Partials      15      16       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@oguzhankoral oguzhankoral marked this pull request as draft February 20, 2025 11:16
@oguzhankoral
Copy link
Member

Since this PR touches the IdleManager which would effect the all connectors that means need to be tested widely. I would rather to have this imporevements in after end of Feb release. Thats why i marked it as draft.

Copy link

linear bot commented Feb 26, 2025

@oguzhankoral oguzhankoral marked this pull request as ready for review March 6, 2025 11:00
adamhathcock and others added 2 commits March 6, 2025 11:19
it is more safe with this way bc we might accidentially skip some deferred actions if we use class name
@adamhathcock adamhathcock enabled auto-merge (squash) March 6, 2025 12:06
@adamhathcock adamhathcock disabled auto-merge March 6, 2025 12:06
@adamhathcock adamhathcock enabled auto-merge (squash) March 6, 2025 12:06
Copy link
Member

@oguzhankoral oguzhankoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks good

@adamhathcock adamhathcock merged commit 950c837 into dev Mar 6, 2025
5 checks passed
@adamhathcock adamhathcock deleted the adam/idle-faster branch March 6, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants