-
Notifications
You must be signed in to change notification settings - Fork 27
fix: Autocad perf - Adds early exit to idle manager to shortcut call check #609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #609 +/- ##
========================================
- Coverage 8.71% 8.66% -0.05%
========================================
Files 227 227
Lines 4374 4374
Branches 546 547 +1
========================================
- Hits 381 379 -2
- Misses 3978 3979 +1
- Partials 15 16 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Since this PR touches the IdleManager which would effect the all connectors that means need to be tested widely. I would rather to have this imporevements in after end of Feb release. Thats why i marked it as draft. |
it is more safe with this way bc we might accidentially skip some deferred actions if we use class name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and looks good
Part of https://linear.app/speckle/issue/CNX-1324/improving-send-and-receive-perf
Since Autocad calls object changed on each receive, this shaves off 7 seconds off my test. Also fixes a namespace
Should talk about Transactions vs StartStop ones
before:

after:
