Build subset when tagged #649
Conversation
adamhathcock
force-pushed
the
adam/cnx-1367-build-subset-when-tagged
branch
from
aad8b9a to
d6aa708
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #649 +/- ##
=======================================
Coverage 15.46% 15.46%
=======================================
Files 230 230
Lines 4604 4604
Branches 550 550
=======================================
Hits 712 712
Misses 3864 3864
Partials 28 28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -9,10 +9,10 @@ | |||
| ], | |||
| "rollForward": false | |||
| }, | |||
| "gitversion.tool": { | |||
There was a problem hiding this comment.
dont we need gitversion anymore?
There was a problem hiding this comment.
Nope, we don't use it at all. At best it was a convenance to get the current tag but that's little of what we need.
|
|
||
| public static async Task<string> GetPreviousTag(string currentTag) | ||
| { | ||
| var (lastTag, _) = await ReadAsync("git", $"describe --abbrev=0 --tags {currentTag}^"); |
There was a problem hiding this comment.
does this consider the versioned tags? as use case scenario, if someone push a tag for any reason to anchor a commit, we could get the wrong state by any chance?
There was a problem hiding this comment.
a tag is a tag....we parse it and it fails the build
does math between two tags and use affected when patch
found nuget changes too:
