Skip to content

Conversation

jhdempsey86
Copy link
Contributor

Description

For unknown reasons, sometimes trying to get the PropertySetDefinitionName throws an exception. Updated to catch this, ignore that property set, and move to the next one. It is never the "Corridor Identity" property set that has this issue, so there should be no missing data.

User Value

Stops the conversion from failing due to an erroneous property set whose data is not stored wit the corridor

Changes:

Caught error when trying to access PropertySetDefinitionName property and continues to next property set.

To-do before merge:

None

Screenshots:

image

Validation of changes:

Checklist:

  • [ X ] My commits are related to the pull request and do not amend unrelated code or documentation.

For unknown reasons, sometimes trying to get the PropertySetDefinitionName throws an exception.
Updated to catch this, ignore that propery set, and move to the next one. It is never the "Corridor Identity" property set that has this issue, so there should be no missing data.
@jhdempsey86 jhdempsey86 changed the title fic(Civil3D): Update CorridorDisplayValueExtractor.cs to fix PropertySetDefinitionName error fix(Civil3D): Update CorridorDisplayValueExtractor.cs to fix PropertySetDefinitionName error Mar 12, 2025
@JR-Morgan JR-Morgan requested a review from clairekuang March 13, 2025 12:53
@clairekuang
Copy link
Member

Hey Jon, looks fine to me. Just make sure you update the formatting issue so your pr passes our ci!

Copy link
Member

@clairekuang clairekuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatting on 141

Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.61%. Comparing base (be63b4a) to head (23f1fe2).
Report is 10 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #669      +/-   ##
==========================================
+ Coverage   15.45%   17.61%   +2.15%     
==========================================
  Files         230      236       +6     
  Lines        4606     5014     +408     
  Branches      551      615      +64     
==========================================
+ Hits          712      883     +171     
- Misses       3866     4103     +237     
  Partials       28       28              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@clairekuang clairekuang self-requested a review March 17, 2025 13:54
@clairekuang clairekuang merged commit 6d336fb into specklesystems:dev Mar 17, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants