feat(revit): adds level extractor and levels to revit objects #679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttps://github.com/specklesystems/speckle-sharp-connectors into claire/cnx-1413-add-level-property-to-revitobject
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #679 +/- ##
==========================================
- Coverage 15.45% 14.51% -0.95%
==========================================
Files 230 232 +2
Lines 4606 4906 +300
Branches 551 606 +55
==========================================
Hits 712 712
- Misses 3866 4166 +300
Partials 28 28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| public LevelExtractor() { } | ||
|
|
||
| public string? GetLevel(DB.Element element) |
There was a problem hiding this comment.
@bjoernsteinhagen once we merge this PR in, we should reconsider this class bv of ID management on cache.
There was a problem hiding this comment.
Yes sir, thanks for the ping!
oguzhankoral
approved these changes
Mar 17, 2025
oguzhankoral
deleted the
claire/cnx-1413-add-level-property-to-revitobject
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
levelstring (name of the level) to all revit objects. Uses a level extractor class with a cache to do so. This pr is dependent on specklesystems/speckle-sharp-sdk#257 and should be updated with new nugets when sdk pr is merged in.User Value
Automations relying on
levelcan now be updated to check the revitobject property directly.Changes:
To-do before merge:
Screenshots:
Sample commit from revit objects file: https://latest.speckle.systems/projects/2295cb26a0/models/33bb362eab@f32aa46a6d
Sample commit from revit sample house: https://latest.speckle.systems/projects/3f895e614f/models/6a8a0f233d@8d1548dda6
objects with level:
objects without level:
Validation of changes:
Sent objects file and revit sample house
Checklist: