Feat(accounts): Add remove account to binding #680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #680 +/- ##
==========================================
- Coverage 15.45% 15.41% -0.05%
==========================================
Files 230 230
Lines 4606 4619 +13
Branches 551 554 +3
==========================================
Hits 712 712
- Misses 3866 3879 +13
Partials 28 28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
didimitrie
reviewed
Mar 15, 2025
| @@ -67,6 +67,8 @@ ITopLevelExceptionHandler topLevelExceptionHandler | |||
|
|
|||
| public void RemoveModel(ModelCard model) => _store.RemoveModel(model); | |||
|
|
|||
| public void RemoveModels(List<ModelCard> models) => _store.RemoveModels(models); | |||
There was a problem hiding this comment.
See corollary comment in FE PR: specklesystems/speckle-server#4203 (comment)
tl;dr: do we need this vs. removing models in a for loop?
There was a problem hiding this comment.
got my reply in the other pr
didimitrie
approved these changes
Mar 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a first pass. And tested via console, it does what it supposed to do.