Skip to content

Conversation

adamhathcock
Copy link
Member

No description provided.

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 48 lines in your changes missing coverage. Please review.

Project coverage is 8.23%. Comparing base (dfe2f71) to head (82df0ea).

Files Patch % Lines
...le.Connectors.Utils/Operations/ReceiveOperation.cs 0.00% 28 Missing ⚠️
...k/Speckle.Connectors.Utils/Common/SpeckleLogger.cs 0.00% 16 Missing ⚠️
...le.Connectors.Utils/Common/SpeckleLoggerFactory.cs 0.00% 3 Missing ⚠️
...fac/DependencyInjection/SpeckleContainerBuilder.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             dev     #89      +/-   ##
========================================
+ Coverage   8.19%   8.23%   +0.04%     
========================================
  Files        231     232       +1     
  Lines       4395    4371      -24     
  Branches     509     497      -12     
========================================
  Hits         360     360              
+ Misses      4025    4001      -24     
  Partials      10      10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamhathcock adamhathcock marked this pull request as ready for review August 7, 2024 07:31
@adamhathcock adamhathcock enabled auto-merge (squash) August 7, 2024 07:31
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JR-Morgan
JR-Morgan previously approved these changes Aug 7, 2024
Copy link
Member

@JR-Morgan JR-Morgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, we'll polish the exact instrumentation usage later

@adamhathcock adamhathcock merged commit 5f9c718 into dev Aug 7, 2024
5 checks passed
@adamhathcock adamhathcock deleted the otel5 branch August 7, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants