Adam/cxpla 6 kill remaining kit code in core #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #59 +/- ##
===========================================
+ Coverage 27.09% 44.96% +17.87%
===========================================
Files 373 389 +16
Lines 13656 14234 +578
Branches 1296 1144 -152
===========================================
+ Hits 3700 6401 +2701
+ Misses 9714 7550 -2164
- Partials 242 283 +41 ☔ View full report in Codecov by Sentry. |
JR-Morgan
reviewed
Aug 6, 2024
JR-Morgan
reviewed
Aug 6, 2024
…ining-kit-code-in-core
JR-Morgan
requested changes
Aug 7, 2024
JR-Morgan
approved these changes
Aug 8, 2024
JR-Morgan
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/speckle/issue/CXPLA-6/kill-remaining-kit-code-in-core