Skip to content

Reimplement bruteforce module #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 9, 2022
Merged

Reimplement bruteforce module #408

merged 5 commits into from
Oct 9, 2022

Conversation

equal-l2
Copy link
Contributor

@equal-l2 equal-l2 commented Oct 6, 2022

Close #7.

genact.mp4

svenstaro
svenstaro requested changes Oct 7, 2022
View reviewed changes
Copy link
Owner

@svenstaro svenstaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this and it looks awesome! The general logic in the code is good but I think we can clean up the surrounding code a bit and maybe even slim this down a bit.

src/modules/bruteforce.rs Outdated
}
}

// color a string rainbow
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might it be more maintainable to use colorful here? We will have to check whether it breaks the web version, though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know that crates!
I'll look into it.

Copy link
Contributor Author

@equal-l2 equal-l2 Oct 7, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use 24-bit colors?
colorful seems not to work without 24-bit color support.

Even in 2022, there are still a few terminal emulators without full-color support (macOS terminal, for example)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, can I use 256 colors instead of ANSI 8 colors?
It will make the step of the rainbow colors smoother.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found colorgrad, which generates gradient colors.
I reimplemented the rainbow progress bar with it, along with the smoother colors using 256 colors in 098bfd1.

Screenshot 2022-10-08 at 12 45 23

@svenstaro
Copy link
Owner

Super nice. Very cool module and clean implementation. Thanks!

@svenstaro svenstaro merged commit f67f43e into svenstaro:master Oct 9, 2022
@svenstaro
Copy link
Owner

How about expanding this a bit and having it crack more than just a single hash?

@equal-l2
Copy link
Contributor Author

equal-l2 commented Oct 9, 2022

Does this match up to what you expected?

Untitled.mov

@svenstaro
Copy link
Owner

Hell yes :D

@equal-l2
Copy link
Contributor Author

equal-l2 commented Oct 9, 2022

Then I'll make a PR with it soon!

@equal-l2 equal-l2 mentioned this pull request Oct 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svenstaro svenstaro svenstaro requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reimplement old module: bruteforce
2 participants
@equal-l2 @svenstaro