[cxx-interop] Simplify std::string construction in the overlay
#83727
+14
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libc++ provides a 2-parameter constructor of `std::string`, so we can apply the logic under `#if os(Windows)` on Apple platforms too. This avoids deserialization issues when building some complex projects that are still under investigation. rdar://145939013
egorzhdan
requested review from
zoecarver,
Xazax-hun,
j-hui,
fahadnayyar and
susmonteiro
as code owners
|
@swift-ci please smoke test |
Xazax-hun
approved these changes
Aug 14, 2025
j-hui
approved these changes
Aug 14, 2025
Comment on lines
+30
to
+31
| // Note that we might be compiling with libc++ on Linux, even if it's not | ||
| // the default stdlib on a particular distro. |
There was a problem hiding this comment.
Just wondering: is there any way to detect which CxxStdlib we're compiling against/importing? Though I'm not sure that'll really help us solve the issue here, since we probably won't actually know that information when we compile the overlay.
There was a problem hiding this comment.
Not at the moment, no.
Ideally we would extend something like if #targetEnvironment or if #available to allow checking for the C++ stdlib that's being used, but that isn't implemented yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libc++ provides a 2-parameter constructor of
std::string, so we can apply the logic under#if os(Windows)on Apple platforms too.This avoids deserialization issues when building some complex projects that are still under investigation.
rdar://145939013