Skip to content

the standard slide_hash implementation vectorizes well on avx2 #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2025
Merged

the standard slide_hash implementation vectorizes well on avx2 #298

merged 1 commit into from
Feb 21, 2025

Conversation

folkertdev
Copy link
Collaborator

So let's use it and ditch the intrinsics. https://godbolt.org/z/sGbdYba7K shows the codegen.

@codecov Codecov
Copy link

codecov bot commented Feb 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
zlib-rs/src/deflate/slide_hash.rs 99.13% <100.00%> (-0.02%) ⬇️

... and 2 files with indirect coverage changes

@folkertdev folkertdev force-pushed the vectorize-slide-hash-avx2 branch from 77470f0 to 9d40fb5 Compare February 21, 2025 10:04
@folkertdev folkertdev merged commit c7c392c into main Feb 21, 2025
20 checks passed
@folkertdev folkertdev deleted the vectorize-slide-hash-avx2 branch February 21, 2025 10:12
@BrewTestBot BrewTestBot mentioned this pull request Apr 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorn3 bjorn3 bjorn3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@folkertdev @bjorn3