fix alignment in zeroed allocations #328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
🚀 New features to boost your workflow:
|
folkertdev
force-pushed
the
zeroed-allocation-alignment
branch
from
95b27fd to
69659f5
Compare
bjorn3
reviewed
Apr 1, 2025
| @@ -251,7 +270,11 @@ impl Allocator<'_> { | |||
| fn allocate_layout_zeroed(&self, layout: Layout) -> *mut c_void { | |||
| #[cfg(feature = "rust-allocator")] | |||
| if self.zalloc == Allocator::RUST.zalloc { | |||
| return unsafe { std::alloc::System.alloc_zeroed(layout).cast() }; | |||
| let ptr = unsafe { zalloc_rust_calloc(self.opaque, layout.size() as _, 1) }; | |||
There was a problem hiding this comment.
Why is the input alignment now ignored entirely?
There was a problem hiding this comment.
hmm, I'll add some asserts then. There is little we can do about it, but we know that our allocations never have alignments higher than 64.
bjorn3
approved these changes
Apr 1, 2025
folkertdev
force-pushed
the
zeroed-allocation-alignment
branch
from
cedab6d to
be1026a
Compare
it's allocator is quite different, so let's test that
folkertdev
force-pushed
the
zeroed-allocation-alignment
branch
from
be1026a to
3c9cbcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using an incorrect alignment is UB (on some platforms, e.g. miri caught it on windows, but not on linux)