Skip to content

Conversation

gupnik
Copy link
Collaborator

@gupnik gupnik commented Apr 8, 2025

Description

Fixes #4348

Updates protobuf to 3.20.3 to support CMake 4.0.0.

How to test

CI Tests

Types of changes

Checklist

  • Create pull request as draft initially, unless its complete.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • If there is a related Issue, mention it in the description.

If you're adding a new blockchain

  • I have read the guidelines for adding a new blockchain.

@gupnik gupnik requested a review from satoshiotomakan as a code owner April 8, 2025 10:49
Copy link

github-actions bot commented Apr 8, 2025

Binary size comparison

➡️ aarch64-apple-ios: 13.93 MB

➡️ aarch64-apple-ios-sim: 13.93 MB

➡️ aarch64-linux-android: 18.35 MB

➡️ armv7-linux-androideabi: 15.37 MB

➡️ wasm32-unknown-emscripten: 13.06 MB

@gupnik gupnik mentioned this pull request Apr 8, 2025
5 tasks
Copy link
Collaborator

@satoshiotomakan satoshiotomakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @gupnik

@satoshiotomakan satoshiotomakan merged commit 798ee95 into master Apr 8, 2025
14 checks passed
@satoshiotomakan satoshiotomakan deleted the gupnik/protobuf-upgrade branch April 8, 2025 12:47
enriquesouza pushed a commit to enriquesouza/wallet-core that referenced this pull request Apr 18, 2025
* Upgrades protobuf to 3.20.3

* Updates files

* Use sorted list

* Updates yml

* Updates project.yml as well

* Updates symlink
zkrypt-crossbar pushed a commit to Cramiumlabs/wallet-core that referenced this pull request Jun 15, 2025
* Upgrades protobuf to 3.20.3

* Updates files

* Use sorted list

* Updates yml

* Updates project.yml as well

* Updates symlink
zkrypt-crossbar pushed a commit to Cramiumlabs/wallet-core that referenced this pull request Jun 21, 2025
* Upgrades protobuf to 3.20.3

* Updates files

* Use sorted list

* Updates yml

* Updates project.yml as well

* Updates symlink
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

after use new version of gtest, still error with cmake when bootstrap.sh
2 participants