Skip to content

Conversation

10gic
Copy link
Contributor

@10gic 10gic commented Apr 13, 2025

Description

Support signing EIP 7702 transactions with a sign server, e.g., AWS KMS.

How to test

Types of changes

Checklist

  • Create pull request as draft initially, unless its complete.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • If there is a related Issue, mention it in the description.

If you're adding a new blockchain

  • I have read the guidelines for adding a new blockchain.

@10gic
Copy link
Contributor Author

10gic commented Apr 14, 2025

Hi @satoshiotomakan @gupnik, could you please take some time to review it? Any feedback or suggestions would be greatly appreciated. Thanks for your help!

@10gic 10gic force-pushed the support-sign-eip7702-tx-with-sign-server branch from 7585279 to 7a52c1e Compare April 14, 2025 08:32
Copy link
Collaborator

@satoshiotomakan satoshiotomakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @10gic, thanks for the PR
Please consider my proposal, feel free to propose other struct names

@satoshiotomakan satoshiotomakan merged commit 8382346 into trustwallet:master Apr 14, 2025
12 checks passed
enriquesouza pushed a commit to enriquesouza/wallet-core that referenced this pull request Apr 18, 2025
…MS. (trustwallet#4363)

* Support signing EIP 7702 transactions with a sign server, e.g., AWS KMS.

* chore: rename MaybeOtherAuthFields to AuthorizationCustomSignature
zkrypt-crossbar pushed a commit to Cramiumlabs/wallet-core that referenced this pull request Jun 15, 2025
…MS. (trustwallet#4363)

* Support signing EIP 7702 transactions with a sign server, e.g., AWS KMS.

* chore: rename MaybeOtherAuthFields to AuthorizationCustomSignature
zkrypt-crossbar pushed a commit to Cramiumlabs/wallet-core that referenced this pull request Jun 21, 2025
…MS. (trustwallet#4363)

* Support signing EIP 7702 transactions with a sign server, e.g., AWS KMS.

* chore: rename MaybeOtherAuthFields to AuthorizationCustomSignature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants