Feat/nftb 143 update cs fixer #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wimsims
commented
Jun 10, 2025
composer.json
Outdated
| @@ -4,7 +4,8 @@ | |||
| "license": "MIT", | |||
| "description": "Worldia Coding Standards", | |||
| "require": { | |||
| "friendsofphp/php-cs-fixer": "^3.6" | |||
| "friendsofphp/php-cs-fixer": "^3.6", | |||
| "ext-json": "*" | |||
There was a problem hiding this comment.
The reason for this addition is php-cs-fixer :
composer why ext-json
Package "ext-json *" found in version "8.3.12".
worldia/coding-standards dev-master requires ext-json (*)
friendsofphp/php-cs-fixer v3.75.0 requires ext-json (*)
Wimsims
commented
Jun 10, 2025
| @@ -4,6 +4,7 @@ | |||
| "license": "MIT", | |||
| "description": "Worldia Coding Standards", | |||
| "require": { | |||
| "ext-json": "*", | |||
There was a problem hiding this comment.
The reason to add this is because of php-cs-fixer :
composer why ext-json
Package "ext-json *" found in version "8.3.12".
worldia/coding-standards dev-master requires ext-json (*)
friendsofphp/php-cs-fixer v3.75.0 requires ext-json (*)
|
Didn't you want to also add the header comment rule ? |
The rules is already present in the factory coding-standards/src/Factory.php Line 28 in 6c4656a Unfortunately, it won't be personalized based on the folder your are on. I think https://github.com/easy-coding-standard/easy-coding-standard may be able to do it. To note, the rule is disabled in integrated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.