fix: prevent file copy in stdout mode for remote repositories #684
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe change updates the control flow in the remote action logic so that the output file is only copied to the current working directory if the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant CLI
participant RemoteAction
User->>CLI: Run with --remote and optional --stdout
CLI->>RemoteAction: Execute remote action
RemoteAction->>RemoteAction: Process repository
alt stdout is enabled
RemoteAction-->>CLI: Output to stdout (no file copy)
else
RemoteAction->>RemoteAction: Copy output file to cwd
end
CLI-->>User: Return result
Assessment against linked issues
Possibly related PRs
✨ Finishing Touches🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Claude finished @yamadashy's task —— View job PR Review CompleteTodo List:
Code Review Feedback✅ Overall Assessment: APPROVE This is a clean, targeted fix that correctly addresses the root cause of issue #673. The solution is minimal, logical, and follows the existing code patterns. Specific Review Comments✅ Fix Implementation (src/cli/actions/remoteAction.ts:94-97) // Copy output file only when not in stdout mode
if (!cliOptions.stdout) {
await copyOutputToCurrentDirectory(tempDirPath, process.cwd(), result.config.output.filePath);
}Strengths:
✅ Code Quality
✅ Potential Issues Analysis
Architecture & Design✅ Design Decision Testing ConsiderationsBased on the PR description, the author has:
Minor Suggestions💡 Optional Enhancement: Consider adding a trace log for consistency: if (!cliOptions.stdout) {
await copyOutputToCurrentDirectory(tempDirPath, process.cwd(), result.config.output.filePath);
} else {
logger.trace('Skipping file copy in stdout mode');
}Note: This is purely optional and not necessary for the fix to work correctly. SummaryThis PR successfully resolves the false positive error when using Recommendation: ✅ APPROVE and MERGE |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @yamadashy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a specific operational bug where the application would incorrectly report an error when processing remote repositories with output directed to standard output. The change ensures that file copy operations, which are irrelevant in stdout mode, are correctly bypassed, leading to a more robust and accurate command execution flow for this specific flag combination.
Highlights
- Bug Fix: This pull request resolves a false positive error (exit code 1) that occurred when using the
--remoteand--stdoutflags together. Previously, the system would attempt to copy an output file even when output was directed to standard output, leading to an error. - Conditional Logic: A conditional check has been added in
src/cli/actions/remoteAction.tsto ensure that thecopyOutputToCurrentDirectoryfunction is only invoked when the--stdoutflag is not enabled. This correctly bypasses the file copy operation when output is streamed directly to the console.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #684 +/- ##
=======================================
Coverage 90.36% 90.36%
=======================================
Files 99 99
Lines 5541 5543 +2
Branches 1183 1183
=======================================
+ Hits 5007 5009 +2
Misses 534 534 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a bug where using the --remote and --stdout flags together would cause a crash due to an attempt to copy a non-existent file. The change is simple and effective, adding a condition to skip the file copy operation when output is being directed to stdout.
The logic is sound and directly addresses the reported issue. I have included one medium-severity suggestion to improve the design by decoupling the remoteAction from the implementation details of the defaultAction, which could be considered for future refactoring. Overall, this is a solid fix.
Deploying repomix with
|
| Latest commit: |
43d3bd9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ed5fb068.repomix.pages.dev |
| Branch Preview URL: | https://fix-stdout-remote-exit-code.repomix.pages.dev |
When using --remote with --stdout flags together, the command was failing with exit code 1 due to attempting to copy a non-existent output file. In stdout mode, output is written directly to stdout without creating a file, so the copy operation should be skipped. Added explanatory comment to clarify the reasoning behind this check. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
yamadashy
force-pushed
the
fix/stdout-remote-exit-code
branch
from
f6aacf2 to
43d3bd9
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the issue where running the command with both --stdout and --remote flags would result in an error by attempting to copy a non-existent output file.
- Skip file copy operation in stdout mode
- Prevent false positive exit code 1 when using --remote and --stdout together
Summary
Fixes #673 - False positive error with
--stdoutand--remoteflagsWhen using
--remotewith--stdoutflags together, the command was failing with exit code 1 due to attempting to copy a non-existent output file. In stdout mode, output is written directly to stdout without creating a file, so the copy operation should be skipped.Changes
copyOutputToCurrentDirectorywhen--stdoutflag is enabled inremoteAction.ts--remoteand--stdouttogetherTest plan
npm run test- All tests passnpm run lint- No lint errorsnpx repomix --stdout --remote https://github.com/JedWatson/classnames🤖 Generated with Claude Code