feat: support multiple public ips on firewall

[tobiasehlert]

Description

This pull request adds support to have multiple public ips on firewall resource.

Similar implementation as in Azure/terraform-azurerm-caf-enterprise-scale#1243.

Fixes #76

Type of Change

• Non-module change (e.g. CI/CD, documentation, etc.)
• Azure Verified Module updates:
  • Bugfix containing backwards compatible bug fixes
    • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
    • The bug was found by the module author, and no one has opened an issue to report it yet.
  • Feature update backwards compatible feature updates.
  • Breaking changes.
  • Update to documentation

Checklist

• I'm sure there are no other open Pull Requests for the same update/change
• My corresponding pipelines / checks run clean and green without any errors or warnings
• I did run all pre-commit checks

[jaredfholgate]

Hi. I very much appreciate you submitting this PR. I'm just wondering if we can make the implementation a bit cleaner and more scalable for new features moving forward. Thanks

[tobiasehlert]

Hi @jaredfholgate, I've rewritten the logic so that you'd need to specify a map now instead.
In the basic-example you can see, how the whole configuration would look like, since I added a secondary IP there.

One outstanding issue is the moved-block you asked me to look into. From what I can see it's not possible to specify such a think since there is a lack of doing those dynamically. If Terraform would have the option to make the moved-block to be generated by some key/value kind of way, that would be doable, but it isn't.

The end-user of this module would need to specify it's own moved block so that the pip is not recreated. Which was also the reason why I tried to make it non-breaking but made the code much more harder to read.

[jaredfholgate]

@tobiasehlert I have finished some refactoring and tested by deploying main branch and then running a plan with this branch to ensure it does not attempt to change anything. If you are happy with these changes, I will merge to a release branch, so I can run the e2e tests.

[jaredfholgate]

Moved to a release branch