-
Notifications
You must be signed in to change notification settings - Fork 9
feat(qsystem): native gateset decomposition improvements #1059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1059 +/- ##
==========================================
- Coverage 78.24% 78.24% -0.01%
==========================================
Files 102 102
Lines 12785 12783 -2
Branches 12506 12504 -2
==========================================
- Hits 10004 10002 -2
Misses 2125 2125
Partials 656 656
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ouch.
Any way we could test these?
theorem provers? execution dependency on selene? run pytket and compare? |
I will add a test in selene (passing locally) |
Closes #1058 Found using ```python from pytket import Circuit, OpType from pytket.passes import AutoSquash c = Circuit(2).CY(0, 1) AutoRebase({OpType.PhasedX, OpType.Rz, OpType.ZZPhase}).apply(c) AutoSquash({OpType.PhasedX, OpType.Rz}).apply(c) ``` ``` [PhasedX(3, 1) q[0]; PhasedX(1.5, 1) q[1]; ZZPhase(0.5) q[0], q[1]; PhasedX(3, 0.5) q[0]; PhasedX(3.5, 1.5) q[1]; Rz(3.5) q[0]; Rz(2.5) q[1]; ] ```
6f1c44b
to
8c76709
Compare
## 🤖 New release * `tket-qsystem`: 0.19.0 -> 0.20.0 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.20.0](tket-qsystem-v0.19.0...tket-qsystem-v0.20.0) - 2025-08-21 ### New Features - [**breaking**] Update WASM extension ([#1047](#1047)) - *(qsystem)* native gateset decomposition improvements ([#1059](#1059)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/).
Found using
BEGIN_COMMIT_OVERRIDE
fix(qsystem): correct CY decomposition to hardware gateset
feat(qsystem): remove unecessary phasedx wrappers in CZ
END_COMMIT_OVERRIDE