Skip to content

feat(qsystem): native gateset decomposition improvements #1059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 21, 2025
+7 −9
Merged

feat(qsystem): native gateset decomposition improvements #1059

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbb76bc
fix(qsystem): correct CY decomposition to hardware gateset
ss2165 Aug 21, 2025
8c76709
feat(qsystem): remove unecessary phasedx wrappers in CZ
ss2165 Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions tket-qsystem/src/extension/qsystem.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,27 +394,25 @@ pub trait QSystemOpBuilder: Dataflow + UnwrapBuilder + ArrayOpBuilder {

/// Build a CY gate in terms of QSystem primitives.
fn build_cy(&mut self, a: Wire, b: Wire) -> Result<[Wire; 2], BuildError> {
let pi = pi_mul_f64(self, 1.0);
let pi_2 = pi_mul_f64(self, 0.5);
let pi_minus_2 = pi_mul_f64(self, -0.5);
let zero = pi_mul_f64(self, 0.0);

let a = self.add_phased_x(a, pi_minus_2, zero)?;
let a = self.add_phased_x(a, pi, pi)?;
let b = self.add_phased_x(b, pi_minus_2, pi)?;
let [a, b] = self.build_zz_max(a, b)?;
let a = self.add_rz(a, pi_2)?;
let b = self.add_phased_x(b, pi_2, pi_2)?;
let b = self.add_rz(b, pi_minus_2)?;
let a = self.add_phased_x(a, pi, pi_2)?;
let b = self.add_phased_x(b, pi_minus_2, pi_minus_2)?;
let a = self.add_rz(a, pi_minus_2)?;
let b = self.add_rz(b, pi_2)?;
Ok([a, b])
}

/// Build a CZ gate in terms of QSystem primitives.
fn build_cz(&mut self, a: Wire, b: Wire) -> Result<[Wire; 2], BuildError> {
let pi = pi_mul_f64(self, 1.0);
let pi_2 = pi_mul_f64(self, 0.5);
let pi_minus_2 = pi_mul_f64(self, -0.5);

let a = self.add_phased_x(a, pi, pi_2)?;
let [a, b] = self.build_zz_max(a, b)?;
let a = self.add_phased_x(a, pi, pi_minus_2)?;
let b = self.add_rz(b, pi_2)?;
let a = self.add_rz(a, pi_2)?;

Expand Down
Loading