Skip to content
This repository was archived by the owner on Aug 5, 2025. It is now read-only.

Simplify I/O types. Remove unused/proxy chips and gate. #74

Merged
merged 7 commits into from
Feb 26, 2025

Conversation

pmikolajczyk41
Copy link
Member

@pmikolajczyk41 pmikolajczyk41 commented Feb 26, 2025

  1. Remove point_double chip and gate - they are not used. Doubling is done within scalar_multiply gate.
  2. Remove chips for checking whether projective/affine point is on curve. They only proxied input to the gate. Now we are using gate directly.
  3. Remove wrappers for input/output values in curve chips. They usually wrapped a single value into a named field - abandoning them results in a more concise code.

Copy link
Contributor

@guspiel guspiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pmikolajczyk41 pmikolajczyk41 merged commit 2206810 into main Feb 26, 2025
3 checks passed
@pmikolajczyk41 pmikolajczyk41 deleted the simplify-inner-types branch February 26, 2025 12:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants