Skip to content

adding LACP attributes port priority and rate v1 #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

mkilar123
Copy link
Contributor

Changes required to extend the interface configuration capabilities required by one of the Customers.
The change introduces the configuration options for two parameters related to LACP protocol:

  • lacp_port_priority
  • lacp_rate

Tested the parameters with a simple ansible task including following scenarios:
A: mode

  • access port-channel
  • trunk port-channel
  • vpc access port-channel
  • vpc trunk port-channel
    B:
  • specifying non-default values
  • specifying default values
  • omitting the parameter in the task

Snippet of taks used for testing:


  • hosts: EVPN_DCLOUD
    any_errors_fatal: true
    gather_facts: no
    collections:

    • cisco.dcnm

    vars:
    fabric_name: "EVPN_DCLOUD"
    switch_ip: "198.18.133.23"
    switch_ip_2: "198.18.133.24"

    tasks:

    • name: Create port-channel interface
      cisco.dcnm.dcnm_interface:
      fabric: "{{ fabric_name }}"
      state: merged
      config:
      - name: Po12
      type: pc
      switch: ["{{ switch_ip }}"]
      deploy: true
      profile:
      admin_state: true
      mode: trunk
      description: "test"
      access_vlan: 99

lacp_port_priority: 1

lacp_rate: fast

          members: 
            - eth1/6
      - name: vpc7
        type: vpc        
        switch: ["{{ switch_ip }}", "{{ switch_ip_2 }}"]               
        deploy: true                    
        profile:
          admin_state: true               
          mode: trunk                    
          peer1_pcid: 17
          peer2_pcid: 17
          peer1_members:                  
            - e1/7
          peer2_members:                  
            - e1/7
          pc_mode: active
          lacp_port_priority: 1
          lacp_rate: fast
    deploy: true
    check_deploy: false
    override_intf_types: [] 

Documentation updated.
Tests should also be updated

Copy link
Collaborator

@mtarking mtarking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants