Fix: NAT is always configured on sdwan_transport_wan_vpn_interface_ethernet_feature

[rchrabas]

Description

Fix issue, where NAT is always configured on sdwan_transport_wan_vpn_interface_ethernet_feature

Issue #485

Types of Changes

• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Breaking change (fix or feature that would cause existing functionality to change)
• Build/CI change
• Code quality improvement/refactoring/documentation (no functional changes)

Checklist

• My code follows the code style of this project
• N/A I have added tests to cover my changes
• All new and existing tests pass locally

[tzarski0]

It seems this doesn't fix the problem. In the API payload, we have two blocks of configuration:

            "nat":
            {
                "optionType": "default",
                "value": false
            },
            "natAttributesIpv4":
            {
                "natType":
                {
                    "optionType": "default",
                    "value": "interface"
                },
                "udpTimeout":
                {
                    "optionType": "default",
                    "value": 1
                },
                "tcpTimeout":
                {
                    "optionType": "default",
                    "value": 60
                },
                "newStaticNat":
                []
            },

The nat field should always be present. The natAttributesIpv4 should be present only if nat.value is true. Similar fix needed for natAttributesIpv6.

[tzarski0]

@rchrabas looks better now. Could you please resolve conflicts?

[rchrabas]

@tzarski0 done