Skip to content

Hot fix for issue #95 #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: release
Choose a base branch
from
Open

Hot fix for issue #95 #96

wants to merge 3 commits into from

Conversation

HeloiseS
Copy link
Owner

@HeloiseS HeloiseS commented Jun 9, 2023

#95 Should not longer be a problem with this fix in cmd.py

I made sure to catch both "flavours" of slashes so that the windows people also get the error

141         assert MODELS_PATH[-1]=="/" or MODELS_PATH[-1]=='\\', f"DEBUGGING ASSISTANT: Directory MODELS_PATH = {MODELS_PATH}"\ 
142                                                              f"does not end with '/' or '\\' "

@HeloiseS HeloiseS added the bug Something isn't working label Jun 9, 2023
@HeloiseS HeloiseS requested a review from maxbriel June 9, 2023 15:41
maxbriel
maxbriel approved these changes Nov 6, 2023
View reviewed changes
Copy link
Collaborator

@maxbriel maxbriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to make sure that the MODELS_PATH ends correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxbriel maxbriel maxbriel approved these changes

Assignees

@maxbriel maxbriel

@HeloiseS HeloiseS

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HeloiseS @maxbriel