Skip to content

Hot fix for issue #95 #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: release
Choose a base branch
from
Open

Hot fix for issue #95 #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
03118a2
added a comment
May 25, 2023
723b6eb
Merge branch 'release' of github.com:HeloiseS/hoki into release
May 25, 2023
00d862c
added an assert statement in cmd make to check that the last characte…
Jun 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions hoki/cmd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,9 @@ def make(self, mag_filter, col_filters):
f"If you've just done that and it looks like it didn't work, try to restart " \
f"your notebook or terminal ;). "

assert MODELS_PATH[-1]=="/" or MODELS_PATH[-1]=='\\', f"DEBUGGING ASSISTANT: Directory MODELS_PATH = {MODELS_PATH}"\
f"does not end with '/' or '\\' "

self.path = MODELS_PATH


Expand Down
2 changes: 2 additions & 0 deletions hoki/sedfitting/kvn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,6 +289,7 @@ def make_templates(self, # In the refactor this should be split into several fun

self.log_age_cols = log_age_cols

### TODO: put this in a function and make bpass_list_spectra a cached property? (Make binray and single priv.att)
# Making list of relevant spectra files
if binary and single:
self.bpass_list_spectra = glob.glob(self.model_path + 'spectra*')
Expand All @@ -304,6 +305,7 @@ def make_templates(self, # In the refactor this should be split into several fun

self.bpass_list_spectra.sort()

### TODO: also make this a cached property (z_list will need to be a private attribute we can use in the func)
# Allow user to select a list of metallicities?
if z_list is not None:
self.z_list=z_list
Expand Down