new service integration library

[JavierGOrdonnez]

see issue

Moved to ci-service-integration-library. Rework of .osparc, Makefile, and file structure was needed.

Seems to work well; dummy project created with it is able to run "make build" without errors.

closes #114

[JavierGOrdonnez]

Dear @pcrespov , sorry for the lack of context. This is the main PR, which addresses the change of tooling regarding service integration (see issue ). The other one (make "make build" is secondary and work-in-progress).

Regarding the elimination of bin/*, I did so imitating the structured of the more up-to-date cookiecutter of Jupyterlab services, which already uses ci-service-integration-library instead of the old service-integration. @GitHK insisted that we should perform that change - please add your comments.

[pcrespov]

Dear @pcrespov , sorry for the lack of context. This is the main PR, which addresses the change of tooling regarding service integration (see issue ). The other one (make "make build" is secondary and work-in-progress).

Regarding the elimination of bin/*, I did so imitating the structured of the more up-to-date cookiecutter of Jupyterlab services, which already uses ci-service-integration-library instead of the old service-integration. @GitHK insisted that we should perform that change - please add your comments.

Yes, I think here we need to align since there is some misunderstanding

[JavierGOrdonnez]

Hi Pedro, I agree. Let's discuss with @GitHK also. I am busy with other tasks at the moment and this isnt urgent, thus I propose we discuss about this in a few days. Best, Javier.

no longer using ooil file

[pcrespov]

@JavierGOrdonnez no longer using ooil file

@JavierGOrdonnez removing the ooil file may disrupt other users who rely on the contents of the bin directory. Consider:

1. Maintain a Personal Fork: Customize and manage your own repository fork to suit your specific needs.
2. Add a Cookiecutter Option: Introduce an option in the Cookiecutter template to exclude executable helpers, using a post-hook to remove the Makefile and bin/* files when they are unnecessary.

These approaches allow customization without affecting other users.

[GitHK]

@pcrespov I have a question. if he replaces the ooil file with the one form the dockerimage there shouldn't be any difference, right?

[JavierGOrdonnez]

@pcrespov @GitHK Ready for review. Updated based on current state of cookiecutter-jupyter and jupyter-pysonic (updated last week by @GitHK ). Uses latest version of ci-service-integration-library (up to now using service-integration, see #114).

Tested to craft Lucia's new "pymorphosonic" service, and everything seems to be working fine.

[pcrespov]

Please check #115 (comment)

[GitHK]

please ask again for a review when all issues have been sorted out. Thanks

[JavierGOrdonnez]

@GitHK @pcrespov remembered that this was still hanging, and would be useful to have it ready for the Codeathon

closes #114

NB: Pedro, this is not to suit any particular workflow of mine; rather, it is a necessary fix, as it has been found multiple times (Codeathon 2024, @lmoyasans when developing https://git.speag.com/moyasans/pymorphosonic) that the cookiecutter as it currently stands produces workflows that fail upon build. This is a fix to that situation using the updated tooling from @GitHK .

[GitHK]

at least please pin these

[JavierGOrdonnez]

ooil commands still present

[JavierGOrdonnez]

@GitHK ooil still shows up in the "check-image.yml" workflows - but I dont see that generating any issues in the GitHub Actions. Please verify this makes sense.

[JavierGOrdonnez]

ooil also shows up here

[JavierGOrdonnez]

NB: the JupyterLab CookieCutter is already converted to the "new" ci-service-integration-tool (simply pinned to an older version, v1.0.4). @GitHK is there any need to update that one?

out-of-date, please review again

[pcrespov]

I’m not fully on board with these changes and would prefer to double-check with @GitHK. That said, @JavierGOrdonnez mentioned it’s necessary for the hackathon, so I don’t want to block it. I’ll go ahead and unblock for now.