Skip to content

new service integration library #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 31, 2025
Merged
Show file tree
Hide file tree
Changes from 12 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view

This file was deleted.

22 changes: 22 additions & 0 deletions {{cookiecutter.project_slug}}/.github/workflows/check-image.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
name: Build and check image

on: [push, pull_request]

jobs:
verify-image-build:
runs-on: ubuntu-latest
steps:
- name: Checkout repo content
uses: actions/checkout@v2
- name: ooil version
uses: docker://itisfoundation/ci-service-integration-library:v2.1.25
with:
args: ooil --version
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GitHK ooil still shows up in the "check-image.yml" workflows - but I dont see that generating any issues in the GitHub Actions. Please verify this makes sense.

- name: Assemble docker compose spec
uses: docker://itisfoundation/ci-service-integration-library:v2.1.25
with:
args: ooil compose
- name: Build all images if multiple
uses: docker://itisfoundation/ci-service-integration-library:v2.1.25
with:
args: docker compose build
68 changes: 0 additions & 68 deletions {{cookiecutter.project_slug}}/.osparc/Makefile

This file was deleted.

67 changes: 0 additions & 67 deletions {{cookiecutter.project_slug}}/.osparc/bin/activate

This file was deleted.

40 changes: 0 additions & 40 deletions {{cookiecutter.project_slug}}/.osparc/bin/ooil
Copy link
Member

@pcrespov pcrespov Mar 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JavierGOrdonnez no longer using ooil file

@JavierGOrdonnez removing the ooil file may disrupt other users who rely on the contents of the bin directory. Consider:

  1. Maintain a Personal Fork: Customize and manage your own repository fork to suit your specific needs.
  2. Add a Cookiecutter Option: Introduce an option in the Cookiecutter template to exclude executable helpers, using a post-hook to remove the Makefile and bin/* files when they are unnecessary.

These approaches allow customization without affecting other users.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pcrespov I have a question. if he replaces the ooil file with the one form the dockerimage there shouldn't be any difference, right?

This file was deleted.

17 changes: 0 additions & 17 deletions {{cookiecutter.project_slug}}/.osparc/bin/yq

This file was deleted.

5 changes: 3 additions & 2 deletions {{cookiecutter.project_slug}}/.osparc/metadata.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,8 @@ key: simcore/services/{%- if cookiecutter.project_type == "computational" -%}com
type: {{ cookiecutter.project_type }}
integration-version: 1.0.0
version: {{ cookiecutter.version }}
version_display: {{ cookiecutter.version_display }}
description: {{ cookiecutter.project_short_description }}
contact: {{ cookiecutter.contact_email }}
contact: {{ cookiecutter.author_email }}
thumbnail: https://github.com/ITISFoundation/osparc-assets/blob/cb43207b6be2f4311c93cd963538d5718b41a023/assets/default-thumbnail-cookiecutter-osparc-service.png?raw=true
authors:
- name: {{ cookiecutter.author_name }}
Expand All @@ -18,6 +17,7 @@ inputs:
label: input_{{ i+1 }}_label
description: The input {{ i+1 }} description
type: string
# allowed input / output types are "string", "number", "bool", "data:*/*"
defaultValue: some_value(optional)
fileToKeyMap:
somefilename.ext: input_{{ i+1 }}
Expand All @@ -29,6 +29,7 @@ outputs:
label: output_{{ i+1 }}_label
description: The input {{ i+1 }} description
type: string
# allowed input / output types are "string", "number", "bool", "data:*/*"
fileToKeyMap:
somefilename.ext: output_{{ i+1 }}
{% endfor %}
9 changes: 6 additions & 3 deletions {{cookiecutter.project_slug}}/.osparc/runtime.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
restart-policy: no-restart
settings:
- name: constraints
type: string
value:
- node.platform.os == linux
- name: Resources
type: Resources
value:
Limits:
Limits: # TODO Default resource limits. Change if necessary.
NanoCPUs: 1000000000 # 100% of CPU cycles on 1 CPU
MemoryBytes: 2147483648 # 2 Gigabytes

MemoryBytes: 2147483648 # 2 Gigabytes
Loading
Loading