Skip to content

Conversation

nsarlin-zama
Copy link
Contributor

With the release of rust 1.89, stdarch_x86_avx512 has been stabilized and do not need the use of a nightly toolchain.
This PR adds support for these types in the avx512_simd feature.

The nightly_stdsimd feature has been kept for backward compatibility but I can remove it if you prefer.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should also use all(.., any(..)), like in zeroable.rs, not just all(..)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They should also stop requiring the nightly feature, just the avx512_simd feature.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should also use all(.., any(..)), like in zeroable.rs, not just all(..)

Yes indeed! I went a bit too fast on that one.

They should also stop requiring the nightly feature, just the avx512_simd feature.

Ok! I removed it in the last commit

@Lokathor
Copy link
Owner

My first instinct is to remove the nightly feature, but there always might be more nightly types, so it can sit doing nothing for a while. Probably better to keep churn low.

@nsarlin-zama
Copy link
Contributor Author

My first instinct is to remove the nightly feature, but there always might be more nightly types, so it can sit doing nothing for a while. Probably better to keep churn low.

Makes sense, for example the avx512 fp16 types are still nightly gated (but not supported by bytemuck at the moment).

@nsarlin-zama nsarlin-zama requested a review from Lokathor August 20, 2025 09:47
@Lokathor Lokathor merged commit 5b2eb85 into Lokathor:main Aug 22, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants