Skip to content

chore: use new stable avx512 types from rust 1.89 #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 22, 2025
Merged

chore: use new stable avx512 types from rust 1.89 #322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa751db
chore: use new stable avx512 types from rust 1.89
nsarlin-zama Aug 19, 2025
e4db80a
chore: remove uses of the `nightly_stdsimd` feature
nsarlin-zama Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ min_const_generics = [] # MSRV 1.51: support arrays via min_const_generics

wasm_simd = [] # MSRV 1.54.0: support wasm simd types
aarch64_simd = [] # MSRV 1.59.0: support aarch64 simd types
avx512_simd = [] # MSRV 1.72.0: support avx512 simd types
avx512_simd = [] # MSRV 1.89.0: support avx512 simd types

must_cast = [] # MSRV 1.64.0: support the `must` module.
must_cast_extra = ["must_cast"] # MSRV 1.83.0: support mutable references in const
Expand Down
7 changes: 0 additions & 7 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,6 @@
#![cfg_attr(feature = "nightly_docs", feature(doc_cfg))]
#![cfg_attr(feature = "nightly_portable_simd", feature(portable_simd))]
#![cfg_attr(feature = "nightly_float", feature(f16, f128))]
#![cfg_attr(
all(
feature = "nightly_stdsimd",
any(target_arch = "x86_64", target_arch = "x86")
),
feature(stdarch_x86_avx512)
)]

//! This crate gives small utilities for casting between plain data types.
//!
Expand Down
8 changes: 4 additions & 4 deletions src/pod.rs
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should also use all(.., any(..)), like in zeroable.rs, not just all(..)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They should also stop requiring the nightly feature, just the avx512_simd feature.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should also use all(.., any(..)), like in zeroable.rs, not just all(..)

Yes indeed! I went a bit too fast on that one.

They should also stop requiring the nightly feature, just the avx512_simd feature.

Ok! I removed it in the last commit

Original file line number Diff line number Diff line change
Expand Up @@ -156,28 +156,28 @@ where
}

impl_unsafe_marker_for_simd!(
#[cfg(all(target_arch = "x86", any(feature = "nightly_stdsimd", feature = "avx512_simd")))]
#[cfg(all(target_arch = "x86", feature = "avx512_simd"))]
unsafe impl Pod for x86::{
__m512, __m512d, __m512i
}
);

impl_unsafe_marker_for_simd!(
#[cfg(all(target_arch = "x86_64", any(feature = "nightly_stdsimd", feature = "avx512_simd")))]
#[cfg(all(target_arch = "x86_64", feature = "avx512_simd"))]
unsafe impl Pod for x86_64::{
__m512, __m512d, __m512i
}
);

impl_unsafe_marker_for_simd!(
#[cfg(all(target_arch = "x86", feature = "nightly_stdsimd"))]
#[cfg(all(target_arch = "x86", feature = "avx512_simd"))]
unsafe impl Pod for x86::{
__m128bh, __m256bh, __m512bh
}
);

impl_unsafe_marker_for_simd!(
#[cfg(all(target_arch = "x86_64", feature = "nightly_stdsimd"))]
#[cfg(all(target_arch = "x86_64", feature = "avx512_simd"))]
unsafe impl Pod for x86_64::{
__m128bh, __m256bh, __m512bh
}
Expand Down
8 changes: 4 additions & 4 deletions src/zeroable.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,28 +235,28 @@ where
}

impl_unsafe_marker_for_simd!(
#[cfg(all(target_arch = "x86", any(feature = "nightly_stdsimd", feature = "avx512_simd")))]
#[cfg(all(target_arch = "x86", feature = "avx512_simd"))]
unsafe impl Zeroable for x86::{
__m512, __m512d, __m512i
}
);

impl_unsafe_marker_for_simd!(
#[cfg(all(target_arch = "x86_64", any(feature = "nightly_stdsimd", feature = "avx512_simd")))]
#[cfg(all(target_arch = "x86_64", feature = "avx512_simd"))]
unsafe impl Zeroable for x86_64::{
__m512, __m512d, __m512i
}
);

impl_unsafe_marker_for_simd!(
#[cfg(all(target_arch = "x86", feature = "nightly_stdsimd"))]
#[cfg(all(target_arch = "x86", feature = "avx512_simd"))]
unsafe impl Zeroable for x86::{
__m128bh, __m256bh, __m512bh
}
);

impl_unsafe_marker_for_simd!(
#[cfg(all(target_arch = "x86_64", feature = "nightly_stdsimd"))]
#[cfg(all(target_arch = "x86_64", feature = "avx512_simd"))]
unsafe impl Zeroable for x86_64::{
__m128bh, __m256bh, __m512bh
}
Expand Down
Loading