MatrixFactorizations Package #3948
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package and documentation files added
d-torrance
requested changes
Aug 14, 2025
There was a problem hiding this comment.
Thanks for the contribution!
Without diving into the code too much yet, here are a couple quick comments. Also, there are a couple typos:
M2/Macaulay2/packages/MatrixFactorizations/KellerTests.m2:671: documnetation ==> documentation
M2/Macaulay2/packages/MatrixFactorizations/MatrixFactorizationsDOC.m2:707: followig ==> following
d-torrance
requested changes
Aug 14, 2025
M2/Macaulay2/packages/MatrixFactorizations/CIResCompatibility.m2
Outdated
Show resolved
Hide resolved
M2/Macaulay2/packages/MatrixFactorizations/CIResCompatibility.m2
Outdated
Show resolved
Hide resolved
M2/Macaulay2/packages/MatrixFactorizations/ZZdFactorizations.m2
Outdated
Show resolved
Hide resolved
M2/Macaulay2/packages/MatrixFactorizations/ZZdFactorizations.m2
Outdated
Show resolved
Hide resolved
moved more things to packageImports, streamlined some spots, overloaded euler, added tests for adjoinRoot and pruning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new matrix factorizations package, a package for computing with length d matrix factorizations. Authors David Favero, Sasha Pevzner, Tim Tribone, and Keller VandeBogert.