Enhance documentation of algebraic closure #2129
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2129 +/- ##
==========================================
- Coverage 88.13% 88.08% -0.06%
==========================================
Files 99 99
Lines 36925 36925
==========================================
- Hits 32545 32526 -19
- Misses 4380 4399 +19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
thofma
force-pushed
the
th/docac
branch
2 times, most recently
from
022636e to
4ea832e
Compare
lgoettgens
reviewed
Aug 14, 2025
| DocTestSetup = quote | ||
| using Nemo | ||
| end | ||
| ``` | ||
|
|
||
| # Algebraic numbers | ||
| # Algebraic closure of the rational numbers |
There was a problem hiding this comment.
This change will break building the Oscar docs as https://github.com/oscar-system/Oscar.jl/blob/575fe7ae72ef361730345763d468117753021708/docs/src/Fields/intro.md?plain=1#L16 won't reference anything anymore. But I don't think we can avoid that, so please just make sure to prepare a corresponding PR to Oscar that can be merged right after the release of this PR here
- make it agnostic to the encapsulating documentation (Nemo or Oscar) - collapse docstrings to make it not stand out in the Oscar documentation - make all docstrings self contained (with collapsed docstrings this should be fine)
lgoettgens
reviewed
Aug 16, 2025
lgoettgens
approved these changes
Aug 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
documentation
should be fine)