Warnings and strictness #353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this I guess garbage data triggered the idle timer.
dsvensson
commented
Jul 29, 2024
This prevents incorrect invocation of functions.
Almost exclusively updated via dirty search/replaces:
find include -name '*.h' -exec sed -i '' -r 's/\(\);/(void);/g' {} \;
find src -name '*.c' -exec sed -i '' -r 's/\(\)$/(void)/g' {} \;
find src -name '*.c' -exec sed -i '' -r 's/^(((extern|static) )?(void|float|qbool)[^(]+)\(\);/\1(void);/g' {} \;
Followed by a handful of manual cleanups.
Henceforth guarded via -Werror=strlcpy-strlcat-size where supported.
dsvensson
force-pushed
the
warnings
branch
2 times, most recently
from
5acb7b4 to
9478740
Compare
dsvensson
force-pushed
the
warnings
branch
3 times, most recently
from
373e703 to
ee3f485
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both protected by corresponding -Werror=... where available from now on. Added macOS to CI to have at least one platform that supports the strlcpy warning.