Skip to content

Remove //NOPMD on OpenAPI generated imports #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 9, 2024

Conversation

CharlesDuboisSAP
Copy link
Contributor

@CharlesDuboisSAP CharlesDuboisSAP commented Jul 8, 2024

Context

google-java-format cannot format files that have comments in imports, furthermore OpenAPI doesn't specify this comment in their api.mustache file.

Feature scope:

  • Remove //NOPMD on OpenAPI generated imports

Definition of Done

  • Functionality scope stated & covered
  • Tests cover the scope above
  • Error handling created / updated & covered by the tests above
  • Documentation updated
  • Release notes updated

@CharlesDuboisSAP CharlesDuboisSAP self-assigned this Jul 8, 2024
jjtang1985
jjtang1985 previously approved these changes Jul 8, 2024
Copy link
Contributor

@jjtang1985 jjtang1985 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I added a suggestion for the release notes.

Co-authored-by: Junjie Tang <33489572+jjtang1985@users.noreply.github.com>
@CharlesDuboisSAP CharlesDuboisSAP dismissed jjtang1985’s stale review July 9, 2024 09:49

Applied suggestion

@CharlesDuboisSAP CharlesDuboisSAP merged commit 8eda948 into main Jul 9, 2024
15 checks passed
@CharlesDuboisSAP CharlesDuboisSAP deleted the openapi-import-fix branch July 9, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants