Skip to content

Remove //NOPMD on OpenAPI generated imports #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 9, 2024
Merged

Remove //NOPMD on OpenAPI generated imports #496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0ae2f84
Remove `//NOPMD` on OpenAPI generated imports
CharlesDuboisSAP Jul 8, 2024
911fea0
Merge branch 'refs/heads/main' into openapi-import-fix
CharlesDuboisSAP Jul 8, 2024
e0bc481
Added release notes
CharlesDuboisSAP Jul 8, 2024
93cfcff
Update release_notes.md
CharlesDuboisSAP Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...ationTest/sodastore/output/com/sap/cloud/sdk/datamodel/rest/sodastore/api/DefaultApi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@
import com.sap.cloud.sdk.services.openapi.core.AbstractOpenApiService;
import com.sap.cloud.sdk.services.openapi.apiclient.ApiClient;

import com.sap.cloud.sdk.datamodel.rest.sodastore.model.NewSoda ; //NOPMD
import com.sap.cloud.sdk.datamodel.rest.sodastore.model.Soda ; //NOPMD
import com.sap.cloud.sdk.datamodel.rest.sodastore.model.UpdateSoda ; //NOPMD
import com.sap.cloud.sdk.datamodel.rest.sodastore.model.NewSoda;
import com.sap.cloud.sdk.datamodel.rest.sodastore.model.Soda;
import com.sap.cloud.sdk.datamodel.rest.sodastore.model.UpdateSoda;

import java.util.HashMap;
import java.util.List;
Expand Down
2 changes: 1 addition & 1 deletion ...c/main/resources/openapi-generator/mustache-templates/libraries/resttemplate/api.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import com.sap.cloud.sdk.services.openapi.core.OpenApiResponse;
import com.sap.cloud.sdk.services.openapi.core.AbstractOpenApiService;
import com.sap.cloud.sdk.services.openapi.apiclient.ApiClient;

{{#imports}}import {{import}} ; //NOPMD
{{#imports}}import {{import}};
{{/imports}}

import java.util.HashMap;
Expand Down
4 changes: 2 additions & 2 deletions ...on-json/output/com/sap/cloud/sdk/services/apiclassvendorextension/api/AwesomeSodaApi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
import com.sap.cloud.sdk.services.openapi.core.AbstractOpenApiService;
import com.sap.cloud.sdk.services.openapi.apiclient.ApiClient;

import com.sap.cloud.sdk.services.apiclassvendorextension.model.NewSoda ; //NOPMD
import com.sap.cloud.sdk.services.apiclassvendorextension.model.Soda ; //NOPMD
import com.sap.cloud.sdk.services.apiclassvendorextension.model.NewSoda;
import com.sap.cloud.sdk.services.apiclassvendorextension.model.Soda;

import java.util.HashMap;
import java.util.List;
Expand Down
2 changes: 1 addition & 1 deletion ...n-json/output/com/sap/cloud/sdk/services/apiclassvendorextension/api/AwesomeSodasApi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
import com.sap.cloud.sdk.services.openapi.core.AbstractOpenApiService;
import com.sap.cloud.sdk.services.openapi.apiclient.ApiClient;

import com.sap.cloud.sdk.services.apiclassvendorextension.model.Soda ; //NOPMD
import com.sap.cloud.sdk.services.apiclassvendorextension.model.Soda;

import java.util.HashMap;
import java.util.List;
Expand Down
4 changes: 2 additions & 2 deletions ...ension-json/output/com/sap/cloud/sdk/services/apiclassvendorextension/api/DefaultApi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
import com.sap.cloud.sdk.services.openapi.core.AbstractOpenApiService;
import com.sap.cloud.sdk.services.openapi.apiclient.ApiClient;

import com.sap.cloud.sdk.services.apiclassvendorextension.model.Soda ; //NOPMD
import com.sap.cloud.sdk.services.apiclassvendorextension.model.UpdateSoda ; //NOPMD
import com.sap.cloud.sdk.services.apiclassvendorextension.model.Soda;
import com.sap.cloud.sdk.services.apiclassvendorextension.model.UpdateSoda;

import java.util.HashMap;
import java.util.List;
Expand Down
6 changes: 3 additions & 3 deletions ...ension-yaml/output/com/sap/cloud/sdk/services/apiclassvendorextension/api/DefaultApi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@
import com.sap.cloud.sdk.services.openapi.core.AbstractOpenApiService;
import com.sap.cloud.sdk.services.openapi.apiclient.ApiClient;

import com.sap.cloud.sdk.services.apiclassvendorextension.model.NewSoda ; //NOPMD
import com.sap.cloud.sdk.services.apiclassvendorextension.model.Soda ; //NOPMD
import com.sap.cloud.sdk.services.apiclassvendorextension.model.UpdateSoda ; //NOPMD
import com.sap.cloud.sdk.services.apiclassvendorextension.model.NewSoda;
import com.sap.cloud.sdk.services.apiclassvendorextension.model.Soda;
import com.sap.cloud.sdk.services.apiclassvendorextension.model.UpdateSoda;

import java.util.HashMap;
import java.util.List;
Expand Down
2 changes: 1 addition & 1 deletion ...ut-spec-with-anyof-oneof/output/com/sap/cloud/sdk/services/anyofoneof/api/DefaultApi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
import com.sap.cloud.sdk.services.openapi.core.AbstractOpenApiService;
import com.sap.cloud.sdk.services.openapi.apiclient.ApiClient;

import com.sap.cloud.sdk.services.anyofoneof.model.RootObject ; //NOPMD
import com.sap.cloud.sdk.services.anyofoneof.model.RootObject;

import java.util.HashMap;
import java.util.List;
Expand Down
4 changes: 2 additions & 2 deletions ...xtension/output/com/sap/cloud/sdk/services/uppercasefileextension/api/AwesomeSodaApi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
import com.sap.cloud.sdk.services.openapi.core.AbstractOpenApiService;
import com.sap.cloud.sdk.services.openapi.apiclient.ApiClient;

import com.sap.cloud.sdk.services.uppercasefileextension.model.NewSoda ; //NOPMD
import com.sap.cloud.sdk.services.uppercasefileextension.model.Soda ; //NOPMD
import com.sap.cloud.sdk.services.uppercasefileextension.model.NewSoda;
import com.sap.cloud.sdk.services.uppercasefileextension.model.Soda;

import java.util.HashMap;
import java.util.List;
Expand Down
2 changes: 1 addition & 1 deletion ...tension/output/com/sap/cloud/sdk/services/uppercasefileextension/api/AwesomeSodasApi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
import com.sap.cloud.sdk.services.openapi.core.AbstractOpenApiService;
import com.sap.cloud.sdk.services.openapi.apiclient.ApiClient;

import com.sap.cloud.sdk.services.uppercasefileextension.model.Soda ; //NOPMD
import com.sap.cloud.sdk.services.uppercasefileextension.model.Soda;

import java.util.HashMap;
import java.util.List;
Expand Down
4 changes: 2 additions & 2 deletions ...le-extension/output/com/sap/cloud/sdk/services/uppercasefileextension/api/DefaultApi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
import com.sap.cloud.sdk.services.openapi.core.AbstractOpenApiService;
import com.sap.cloud.sdk.services.openapi.apiclient.ApiClient;

import com.sap.cloud.sdk.services.uppercasefileextension.model.Soda ; //NOPMD
import com.sap.cloud.sdk.services.uppercasefileextension.model.UpdateSoda ; //NOPMD
import com.sap.cloud.sdk.services.uppercasefileextension.model.Soda;
import com.sap.cloud.sdk.services.uppercasefileextension.model.UpdateSoda;

import java.util.HashMap;
import java.util.List;
Expand Down
2 changes: 1 addition & 1 deletion release_notes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

### 🔧 Compatibility Notes

-
- The OpenAPI generator doesn't add `//NOPMD` after imports anymore.

### ✨ New Functionality

Expand Down
Loading