.github/workflows/build.yml:build matrix #187
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandyMcMillan
force-pushed
the
2021/850817/694959/b21e96f20/5f001e75c
branch
from
0a7a3f1 to
adf0493
Compare
✅ Deploy Preview for awesome-golick-685c88 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
RandyMcMillan
force-pushed
the
2021/850817/694959/b21e96f20/5f001e75c
branch
from
adf0493 to
325154d
Compare
RandyMcMillan
force-pushed
the
2021/850817/694959/b21e96f20/5f001e75c
branch
from
325154d to
79096a4
Compare
| @@ -3,6 +3,9 @@ name: Build | |||
| on: | |||
| # Run the build for pushes and pull requests targeting master | |||
| push: | |||
| tags: | |||
There was a problem hiding this comment.
Can you tell me what the purpose of this is?
| @@ -14,14 +17,17 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| permissions: | |||
| contents: write | |||
| strategy: | |||
There was a problem hiding this comment.
You're using a matrix but then only setting one version, so it's adding complexity that's not used. Why not simply keep the node-version: 16 as before?
|
Overall my question here is: what is this PR doing that is bettering the codebase? |
|
This PR is stale and doesn't have a clear objective so I'll close it for now, but Randy feel free to reopen if you want to explain a bit more what it was about and why we should merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.