Skip to content

.github/workflows/build.yml:build matrix #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ name: Build
on:
# Run the build for pushes and pull requests targeting master
push:
tags:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you tell me what the purpose of this is?

- '**[0-9]+.[0-9]+.[0-9]+*'
- '**'
branches:
- master
pull_request:
Expand All @@ -14,14 +17,17 @@ jobs:
runs-on: ubuntu-latest
permissions:
contents: write
strategy:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're using a matrix but then only setting one version, so it's adding complexity that's not used. Why not simply keep the node-version: 16 as before?

matrix:
node-version: ['16.x']
steps:
# Checkout and setup
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Setup
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: 16
node-version: ${{ matrix.node-version }}
# Install and build
- name: Install
run: npm ci
Expand Down
4 changes: 4 additions & 0 deletions docs/bdk-cli/installation.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,14 @@ the GitHub repository, by running:
```bash
# all features with the blocking esplora client
cargo install --git https://github.com/bitcoindevkit/bdk-cli --features=esplora-ureq,compiler
```

```bash
# all features with the async esplora client
cargo install --git https://github.com/bitcoindevkit/bdk-cli --features=esplora-reqwest,compiler
```

```bash
# minimal install (only repl feature is on by default)
cargo install --git https://github.com/bitcoindevkit/bdk-cli
```
Expand Down