Skip to content

Conversation

mohamedawnallah
Copy link
Contributor

@mohamedawnallah mohamedawnallah commented Aug 18, 2025

Change Description

Towards #1041.
Towards #1015.

Steps to Test

Steps for reviewers to follow to test the change.

Pull Request Checklist

Testing

  • Your PR passes all CI checks.
  • Tests covering the positive and negative (error paths) are included.
  • Bug fixes contain tests triggering the bug to prevent regressions.

Code Style and Documentation

📝 Please see our Contribution Guidelines for further guidance.

@mohamedawnallah mohamedawnallah changed the title multi: Introduce make fmt-check to CI workflow multi: Introduce fmt-check to CI workflow Aug 18, 2025
@mohamedawnallah mohamedawnallah force-pushed the introduce-fmt-check-workflow branch from cd6161f to bd50d85 Compare August 18, 2025 15:18
@mohamedawnallah mohamedawnallah force-pushed the introduce-fmt-check-workflow branch 2 times, most recently from 747f627 to 582483d Compare August 18, 2025 16:41
@mohamedawnallah mohamedawnallah force-pushed the introduce-fmt-check-workflow branch 3 times, most recently from 651f149 to bc3a736 Compare August 19, 2025 20:51
Copy link
Contributor

@GustavoStingelin GustavoStingelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

Co-authored-by: Gustavo Stingelin <59903150+GustavoStingelin@users.noreply.github.com>
Co-authored-by: Oliver Gugger <gugger@gmail.com>
@mohamedawnallah mohamedawnallah force-pushed the introduce-fmt-check-workflow branch from bc3a736 to c931ade Compare August 20, 2025 08:47
@mohamedawnallah mohamedawnallah force-pushed the introduce-fmt-check-workflow branch from c931ade to 3b9f539 Compare August 20, 2025 08:57
Copy link
Collaborator

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment, otherwise LGTM 🎉

@mohamedawnallah mohamedawnallah force-pushed the introduce-fmt-check-workflow branch from 3b9f539 to 4abc517 Compare August 20, 2025 11:48
Copy link
Collaborator

@yyforyongyu yyforyongyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@yyforyongyu yyforyongyu merged commit 4fd43f6 into btcsuite:master Aug 20, 2025
3 checks passed
@mohamedawnallah mohamedawnallah deleted the introduce-fmt-check-workflow branch August 20, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants