multi: Introduce make rpc and make rpc-check to CI workflow
#1045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohamedawnallah
changed the title
make rpc-check to CI workflowmake rpc and make rpc-check to CI workflow
mohamedawnallah
force-pushed
the
introduce-make-rpc-check-to-workflow
branch
from
f87b74b to
f86e637
Compare
7 tasks
In this commit, we replace the local protoc dependency with a Docker-based solution. This will help in give reproducable and deterministic results across different computing environments.
before adding `make rpc-check` to CI workflow, make sure we ignore capturing protobuf generated files so they don't conflict with `make fmt` and endup fail in the CI
mohamedawnallah
force-pushed
the
introduce-make-rpc-check-to-workflow
branch
from
f86e637 to
9662432
Compare
|
Rebased on master branch. It is now ready for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Depends on #1042.
Towards #1041.
Towards #1015.
Steps to Test
Steps for reviewers to follow to test the change.
Pull Request Checklist
Testing
Code Style and Documentation
📝 Please see our Contribution Guidelines for further guidance.