multi: Introduce make rpc and make rpc-check to CI workflow

.github/workflows/main.yml

@@ -48,6 +48,9 @@ jobs:
       - name: Check code format
         run: make fmt-check
 
+      - name: Check RPC format
+        run: make rpc-check
+
       - name: compile code
         run: go install -v ./...
 

Makefile

@@ -29,7 +29,7 @@ GOTEST := GO111MODULE=on go test
 
 GOLIST := go list -deps $(PKG)/... | grep '$(PKG)'
 GOLIST_COVER := $$(go list -deps $(PKG)/... | grep '$(PKG)')
-GOFILES_NOVENDOR = $(shell find . -type f -name '*.go' -not -path "./vendor/*")
+GOFILES_NOVENDOR = $(shell find . -type f -name '*.go' -not -path "./vendor/*" -not -name "*.pb.go")
 
 RM := rm -f
 CP := cp
@@ -131,6 +131,16 @@ lint: $(LINT_BIN)
 	@$(call print, "Linting source.")
 	$(LINT)
 
+#? rpc: Compile protobuf definitions
+rpc:
+	@$(call print, "Compiling protos.")
+	cd ./rpc; ./gen_protos_docker.sh
+
+#? rpc-check: Make sure protobuf definitions are up to date
+rpc-check: rpc
+	@$(call print, "Verifying protos.")
+	if test -n "$$(git status --porcelain rpc/walletrpc/)"; then echo "Generated protobuf files are not up-to-date. Please run 'make rpc' and commit the changes."; git status; git diff rpc/walletrpc/; exit 1; fi
+
 #? clean: Clean source
 clean:
 	@$(call print, "Cleaning source.$(NC)")
@@ -155,6 +165,8 @@ tidy-module-check: tidy-module
 	fmt \
 	fmt-check \
 	lint \
+	rpc \
+	rpc-check \
 	clean
 
 #? help: Get more info on make commands

rpc/documentation/serverchanges.md

@@ -66,7 +66,7 @@ A `sh` shell script is included to compile the Protocol Buffers descriptor.  It
 must be run from the `rpc` directory.
 
 ```bash
-$ sh regen.sh
+$ sh gen_protos_docker.sh
 ```
 
 If a `sh` shell is unavailable, the command can be run manually instead (again

rpc/gen_protos_docker.sh

@@ -0,0 +1,16 @@
+#!/bin/sh
+
+# golang docker image version used in this script.
+GO_IMAGE=docker.io/library/golang:1.23.12-alpine
+
+# protobuf generator version with legacy plugins=grpc support. Using v1.4.3 to
+# maintain backward compatibility - generates single file instead of separate
+# .pb.go and _grpc.pb.go files (modern approach).
+PROTOC_GEN_GO_VERSION=v1.4.3
+
+docker run --rm --volume "$(pwd):/workspace" --workdir /workspace \
+    ${GO_IMAGE} sh -c "
+    apk add --no-cache protobuf-dev && \
+    go install github.com/golang/protobuf/protoc-gen-go@${PROTOC_GEN_GO_VERSION} && \
+    protoc -I. api.proto --go_out=plugins=grpc:walletrpc && \
+    chown -R $(id -u):$(id -g) walletrpc"