-
Notifications
You must be signed in to change notification settings - Fork 636
multi: Introduce protolint
to CI workflow and make rpc-format
util
#1044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
yyforyongyu
merged 8 commits into
btcsuite:master
from
mohamedawnallah:introduce-protolint-to-workflow
Aug 27, 2025
Merged
multi: Introduce protolint
to CI workflow and make rpc-format
util
#1044
yyforyongyu
merged 8 commits into
btcsuite:master
from
mohamedawnallah:introduce-protolint-to-workflow
Aug 27, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
90bc656
to
f9a584b
Compare
protolint
to CI workflowprotolint
to CI workflow and make rpc-format
util
yyforyongyu
reviewed
Aug 19, 2025
7 tasks
Needs a rebase, otherwise good to go! |
aa9ee1e
to
e514986
Compare
cc @GustavoStingelin for review |
GustavoStingelin
approved these changes
Aug 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
Cool this is now missing a rebase! |
49f4236
to
8560f34
Compare
Rebased now 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Towards #1041.
Towards #1015.
Steps to Test
Steps for reviewers to follow to test the change.
Pull Request Checklist
Testing
Code Style and Documentation
📝 Please see our Contribution Guidelines for further guidance.