Skip to content

Conversation

mohamedawnallah
Copy link
Contributor

Change Description

Towards #1041.
Towards #1015.

Steps to Test

Steps for reviewers to follow to test the change.

Pull Request Checklist

Testing

  • Your PR passes all CI checks.
  • Tests covering the positive and negative (error paths) are included.
  • Bug fixes contain tests triggering the bug to prevent regressions.

Code Style and Documentation

📝 Please see our Contribution Guidelines for further guidance.

@mohamedawnallah mohamedawnallah force-pushed the introduce-protolint-to-workflow branch from 90bc656 to f9a584b Compare August 18, 2025 17:27
@mohamedawnallah mohamedawnallah changed the title multi: Introduce protolint to CI workflow multi: Introduce protolint to CI workflow and make rpc-format util Aug 19, 2025
@yyforyongyu
Copy link
Collaborator

Needs a rebase, otherwise good to go!

@mohamedawnallah mohamedawnallah force-pushed the introduce-protolint-to-workflow branch 2 times, most recently from aa9ee1e to e514986 Compare August 25, 2025 11:15
@yyforyongyu
Copy link
Collaborator

cc @GustavoStingelin for review

Copy link
Contributor

@GustavoStingelin GustavoStingelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@yyforyongyu
Copy link
Collaborator

Cool this is now missing a rebase!

@mohamedawnallah mohamedawnallah force-pushed the introduce-protolint-to-workflow branch from 49f4236 to 8560f34 Compare August 27, 2025 14:15
@mohamedawnallah
Copy link
Contributor Author

mohamedawnallah commented Aug 27, 2025

Cool this is now missing a rebase!

Rebased now 👍

@yyforyongyu yyforyongyu merged commit 2b84502 into btcsuite:master Aug 27, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants