make+Makefile: Introduce unit test variants #1047
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 21, 2025
mohamedawnallah
force-pushed
the
introduce-unit-variants
branch
from
05cb26e to
91685be
Compare
GustavoStingelin
suggested changes
Aug 21, 2025
mohamedawnallah
force-pushed
the
introduce-unit-variants
branch
from
91685be to
046c335
Compare
7 tasks
yyforyongyu
reviewed
Aug 22, 2025
| @@ -44,12 +44,18 @@ ifeq ($(UNIT_TARGETED), yes) | |||
| UNIT := $(GOTEST) $(TEST_FLAGS) $(UNITPKG) | |||
| UNIT_DEBUG := $(GOTEST) -v $(TEST_FLAGS) $(UNITPKG) | |||
| UNIT_RACE := $(GOTEST) $(TEST_FLAGS) -race $(UNITPKG) | |||
| # NONE is a special value which selects no other tests but only executes the | |||
| endif | ||
|
|
||
| ifeq ($(UNIT_TARGETED), no) | ||
| UNIT := $(GOLIST) | $(XARGS) env $(GOTEST) $(TEST_FLAGS) | ||
| UNIT_DEBUG := $(GOLIST) | $(XARGS) env $(GOTEST) -v $(TEST_FLAGS) | ||
| UNIT_RACE := $(UNIT) -race | ||
| # NONE is a special value which selects no other tests but only executes the |
| env CGO_ENABLED=1 GORACE="history_size=7 halt_on_errors=1" $(UNIT_RACE) | ||
|
|
||
| #? unit-debug: Run unit tests with verbose debug output enabled | ||
| unit-debug: |
There was a problem hiding this comment.
hmm looks like this doesn't print the debug logs,
make unit-debug log="stdlog debug" pkg=wallet case=TestLocateBirthdayBlock timeout=10s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Towards #1041.
Towards #1015.
Motivation and Context
Motivated by @yyforyongyu's comment #1044 (comment)
Steps to Test
Steps for reviewers to follow to test the change.
Pull Request Checklist
Testing
Code Style and Documentation
📝 Please see our Contribution Guidelines for further guidance.