Fix Split chat not working on Livestreams #688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This only highlights the text, not the whole "row"
|
|
The LinearLayout only stretches as far as the text, not the row. I thought of trying to set the width to the whole space, but that might introduce other bugs that could be a headache to deal with. |
Zerwin
force-pushed
the
fix/splitchat
branch
from
9401950 to
f2b6a6b
Compare
Zerwin
force-pushed
the
fix/splitchat
branch
from
f2b6a6b to
7cdc9d8
Compare
|
I made it so that comments are as wide as the parent element now. This should make the entire "row" colored. I tested it for a bit and at least couldn't immediately find any bugs because of this change. |
2 tasks
FoseFx
requested changes
Dec 26, 2024
Co-authored-by: Max Baumann <max@bmn.dev>
Co-authored-by: Max Baumann <max@bmn.dev>
Co-authored-by: Max Baumann <max@bmn.dev> Apply suggestions from code review Co-authored-by: Max Baumann <max@bmn.dev> Update SplitChat.java Fix typo
|
This should be all of the changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #673
Changes
Twitch changed chat messages in Live Streams to be LinearLayouts with the chat_message_item as a child. This fixes it to target the child rather than the LinearLayout to make Split Chat work again.
Checklist
I use the "bttv_" prefix for all resources I proposeWhen adding a string I also added it to thebttv.Res.stringsEnum andres/values/strings.xml(inmod) andres/values/public.xml(indisass)If my change is significant enough, I added it to the CHANGELOG.md undermasterI'll add myself and everyone else who contributed to this change to the contributors list using all-contributors